From 17a7490cabfd4428cfdb5d9106dc076b1dc4b905 Mon Sep 17 00:00:00 2001 From: Tavian Barnes Date: Sat, 4 Oct 2014 12:32:13 -0400 Subject: log4j: Test best practices. --- .../main/java/com/tavianator/sangria/log4j/Log4jLoggerProvider.java | 5 +++++ .../java/com/tavianator/sangria/log4j/SangriaLog4jModuleTest.java | 6 ++++-- 2 files changed, 9 insertions(+), 2 deletions(-) (limited to 'sangria-log4j/src') diff --git a/sangria-log4j/src/main/java/com/tavianator/sangria/log4j/Log4jLoggerProvider.java b/sangria-log4j/src/main/java/com/tavianator/sangria/log4j/Log4jLoggerProvider.java index dae2323..34262d7 100644 --- a/sangria-log4j/src/main/java/com/tavianator/sangria/log4j/Log4jLoggerProvider.java +++ b/sangria-log4j/src/main/java/com/tavianator/sangria/log4j/Log4jLoggerProvider.java @@ -19,6 +19,7 @@ package com.tavianator.sangria.log4j; import javax.inject.Singleton; +import com.google.inject.Inject; import com.google.inject.spi.InjectionPoint; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; @@ -34,6 +35,10 @@ import com.tavianator.sangria.contextual.ContextSensitiveProvider; */ @Singleton class Log4jLoggerProvider implements ContextSensitiveProvider { + @Inject + Log4jLoggerProvider() { + } + @Override public Logger getInContext(InjectionPoint injectionPoint) { return LogManager.getLogger(injectionPoint.getDeclaringType().getRawType()); diff --git a/sangria-log4j/src/test/java/com/tavianator/sangria/log4j/SangriaLog4jModuleTest.java b/sangria-log4j/src/test/java/com/tavianator/sangria/log4j/SangriaLog4jModuleTest.java index d91cf90..a3ecd66 100644 --- a/sangria-log4j/src/test/java/com/tavianator/sangria/log4j/SangriaLog4jModuleTest.java +++ b/sangria-log4j/src/test/java/com/tavianator/sangria/log4j/SangriaLog4jModuleTest.java @@ -29,6 +29,7 @@ import org.apache.logging.log4j.Logger; import org.junit.Before; import org.junit.Test; +import static com.tavianator.sangria.test.SangriaMatchers.*; import static org.hamcrest.Matchers.*; import static org.junit.Assert.*; @@ -74,7 +75,8 @@ public class SangriaLog4jModuleTest { } @Test - public void testDeDuplication() { - Guice.createInjector(new SangriaLog4jModule(), new SangriaLog4jModule()); + public void testBestPractices() { + assertThat(new SangriaLog4jModule(), is(atomic())); + assertThat(new SangriaLog4jModule(), followsBestPractices()); } } -- cgit v1.2.3