summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTavian Barnes <tavianator@tavianator.com>2014-10-04 12:27:26 -0400
committerTavian Barnes <tavianator@tavianator.com>2014-10-04 12:27:26 -0400
commit181bf8b43411ff309517ca6ca804fc34dae1e13a (patch)
treeca148e141d0726dacc444269d2235c247c634565
parentb8c1ca531321dbcee3ae237bad20fa8691b31f83 (diff)
downloadsangria-181bf8b43411ff309517ca6ca804fc34dae1e13a.tar.xz
slf4j: Test best practices.
-rw-r--r--sangria-slf4j/pom.xml6
-rw-r--r--sangria-slf4j/src/main/java/com/tavianator/sangria/slf4j/Slf4jLoggerProvider.java5
-rw-r--r--sangria-slf4j/src/test/java/com/tavianator/sangria/slf4j/SangriaSlf4jModuleTest.java6
3 files changed, 15 insertions, 2 deletions
diff --git a/sangria-slf4j/pom.xml b/sangria-slf4j/pom.xml
index c274a47..53cbfb7 100644
--- a/sangria-slf4j/pom.xml
+++ b/sangria-slf4j/pom.xml
@@ -39,6 +39,12 @@
</dependency>
<dependency>
+ <groupId>com.tavianator.sangria</groupId>
+ <artifactId>sangria-test</artifactId>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<scope>test</scope>
diff --git a/sangria-slf4j/src/main/java/com/tavianator/sangria/slf4j/Slf4jLoggerProvider.java b/sangria-slf4j/src/main/java/com/tavianator/sangria/slf4j/Slf4jLoggerProvider.java
index 916f2b9..bcb7e8b 100644
--- a/sangria-slf4j/src/main/java/com/tavianator/sangria/slf4j/Slf4jLoggerProvider.java
+++ b/sangria-slf4j/src/main/java/com/tavianator/sangria/slf4j/Slf4jLoggerProvider.java
@@ -19,6 +19,7 @@ package com.tavianator.sangria.slf4j;
import javax.inject.Singleton;
+import com.google.inject.Inject;
import com.google.inject.spi.InjectionPoint;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -34,6 +35,10 @@ import com.tavianator.sangria.contextual.ContextSensitiveProvider;
*/
@Singleton
class Slf4jLoggerProvider implements ContextSensitiveProvider<Logger> {
+ @Inject
+ Slf4jLoggerProvider() {
+ }
+
@Override
public Logger getInContext(InjectionPoint injectionPoint) {
return LoggerFactory.getLogger(injectionPoint.getDeclaringType().getRawType());
diff --git a/sangria-slf4j/src/test/java/com/tavianator/sangria/slf4j/SangriaSlf4jModuleTest.java b/sangria-slf4j/src/test/java/com/tavianator/sangria/slf4j/SangriaSlf4jModuleTest.java
index d142bde..aaf72b2 100644
--- a/sangria-slf4j/src/test/java/com/tavianator/sangria/slf4j/SangriaSlf4jModuleTest.java
+++ b/sangria-slf4j/src/test/java/com/tavianator/sangria/slf4j/SangriaSlf4jModuleTest.java
@@ -28,6 +28,7 @@ import org.junit.Before;
import org.junit.Test;
import org.slf4j.Logger;
+import static com.tavianator.sangria.test.SangriaMatchers.*;
import static org.hamcrest.Matchers.*;
import static org.junit.Assert.*;
@@ -75,7 +76,8 @@ public class SangriaSlf4jModuleTest {
}
@Test
- public void testDeDuplication() {
- Guice.createInjector(new SangriaSlf4jModule(), new SangriaSlf4jModule());
+ public void testBestPractices() {
+ assertThat(new SangriaSlf4jModule(), is(atomic()));
+ assertThat(new SangriaSlf4jModule(), followsBestPractices());
}
}