From acd7f7ed437793e7c67ecd869cfac32a87c1ec52 Mon Sep 17 00:00:00 2001 From: Tavian Barnes Date: Sat, 12 Aug 2017 18:12:13 -0400 Subject: Unify broken symlink handling Rather than open-code the fallback logic for broken symlinks everywhere it's needed, introduce a new xfstatat() utility function that performs the fallback automatically. Using xfstatat() consistently fixes a few bugs, including cases where broken symlinks are given as arguments to predicates like -samefile. --- tests/test_H_samefile_broken.out | 1 + tests/test_H_samefile_symlink.out | 2 ++ tests/test_newer_link.out | 1 + tests/test_samefile_broken.out | 1 + tests/test_samefile_symlink.out | 1 + 5 files changed, 6 insertions(+) create mode 100644 tests/test_H_samefile_broken.out create mode 100644 tests/test_H_samefile_symlink.out create mode 100644 tests/test_newer_link.out create mode 100644 tests/test_samefile_broken.out create mode 100644 tests/test_samefile_symlink.out (limited to 'tests') diff --git a/tests/test_H_samefile_broken.out b/tests/test_H_samefile_broken.out new file mode 100644 index 0000000..e5e13fc --- /dev/null +++ b/tests/test_H_samefile_broken.out @@ -0,0 +1 @@ +links/d/e/i diff --git a/tests/test_H_samefile_symlink.out b/tests/test_H_samefile_symlink.out new file mode 100644 index 0000000..892c879 --- /dev/null +++ b/tests/test_H_samefile_symlink.out @@ -0,0 +1,2 @@ +links/a +links/c diff --git a/tests/test_newer_link.out b/tests/test_newer_link.out new file mode 100644 index 0000000..d2dcdd1 --- /dev/null +++ b/tests/test_newer_link.out @@ -0,0 +1 @@ +times diff --git a/tests/test_samefile_broken.out b/tests/test_samefile_broken.out new file mode 100644 index 0000000..e5e13fc --- /dev/null +++ b/tests/test_samefile_broken.out @@ -0,0 +1 @@ +links/d/e/i diff --git a/tests/test_samefile_symlink.out b/tests/test_samefile_symlink.out new file mode 100644 index 0000000..76696d9 --- /dev/null +++ b/tests/test_samefile_symlink.out @@ -0,0 +1 @@ +links/b -- cgit v1.2.3