From 68622a02adfa7ebd3a195667d3fbf8e1f10ca93f Mon Sep 17 00:00:00 2001 From: "Markus F.X.J. Oberhumer" Date: Thu, 15 Apr 2021 07:43:13 +0200 Subject: util: introduce safe versions of read & write that handle interrupted systems calls. --- spawn.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) (limited to 'spawn.c') diff --git a/spawn.c b/spawn.c index 66f5f5e..5878122 100644 --- a/spawn.c +++ b/spawn.c @@ -189,12 +189,9 @@ static void bfs_spawn_exec(const char *exe, const struct bfs_spawn *ctx, char ** fail: error = errno; - while (write(pipefd[1], &error, sizeof(error)) < 0) { - if (errno != EINTR) { - // Parent will still see that we exited unsuccessfully, but won't know why - break; - } - } + // In case of write error parent will still see that we exited + // unsuccessfully, but won't know why. + safe_write(pipefd[1], &error, sizeof(error)); close(pipefd[1]); _Exit(127); @@ -224,7 +221,7 @@ pid_t bfs_spawn(const char *exe, const struct bfs_spawn *ctx, char **argv, char // Parent close(pipefd[1]); - ssize_t nbytes = read(pipefd[0], &error, sizeof(error)); + ssize_t nbytes = safe_read(pipefd[0], &error, sizeof(error)); close(pipefd[0]); if (nbytes == sizeof(error)) { int wstatus; -- cgit v1.2.3