summaryrefslogtreecommitdiffstats
path: root/spawn.c
diff options
context:
space:
mode:
authorMarkus F.X.J. Oberhumer <markus@oberhumer.com>2021-04-15 07:43:13 +0200
committerMarkus F.X.J. Oberhumer <markus@oberhumer.com>2021-04-15 07:43:13 +0200
commit68622a02adfa7ebd3a195667d3fbf8e1f10ca93f (patch)
tree8dd77202cd9cdbf5f59ae42dd3293d87fbabcfbb /spawn.c
parent1d8bbdc1a59fd5246ec60bc3db1ece055ef83639 (diff)
downloadbfs-68622a02adfa7ebd3a195667d3fbf8e1f10ca93f.tar.xz
util: introduce safe versions of read & write that handle interrupted
systems calls.
Diffstat (limited to 'spawn.c')
-rw-r--r--spawn.c11
1 files changed, 4 insertions, 7 deletions
diff --git a/spawn.c b/spawn.c
index 66f5f5e..5878122 100644
--- a/spawn.c
+++ b/spawn.c
@@ -189,12 +189,9 @@ static void bfs_spawn_exec(const char *exe, const struct bfs_spawn *ctx, char **
fail:
error = errno;
- while (write(pipefd[1], &error, sizeof(error)) < 0) {
- if (errno != EINTR) {
- // Parent will still see that we exited unsuccessfully, but won't know why
- break;
- }
- }
+ // In case of write error parent will still see that we exited
+ // unsuccessfully, but won't know why.
+ safe_write(pipefd[1], &error, sizeof(error));
close(pipefd[1]);
_Exit(127);
@@ -224,7 +221,7 @@ pid_t bfs_spawn(const char *exe, const struct bfs_spawn *ctx, char **argv, char
// Parent
close(pipefd[1]);
- ssize_t nbytes = read(pipefd[0], &error, sizeof(error));
+ ssize_t nbytes = safe_read(pipefd[0], &error, sizeof(error));
close(pipefd[0]);
if (nbytes == sizeof(error)) {
int wstatus;