From 8c7d863828e0bf4b9045075ff3ccd386993dfbb5 Mon Sep 17 00:00:00 2001 From: Tavian Barnes Date: Fri, 10 Jul 2015 22:01:30 -0400 Subject: lazy: Fix Lazy when a provider returns null. --- .../java/com/tavianator/sangria/lazy/LazyTest.java | 27 +++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) (limited to 'sangria-lazy/src/test/java/com/tavianator/sangria/lazy/LazyTest.java') diff --git a/sangria-lazy/src/test/java/com/tavianator/sangria/lazy/LazyTest.java b/sangria-lazy/src/test/java/com/tavianator/sangria/lazy/LazyTest.java index ee6200a..a451a96 100644 --- a/sangria-lazy/src/test/java/com/tavianator/sangria/lazy/LazyTest.java +++ b/sangria-lazy/src/test/java/com/tavianator/sangria/lazy/LazyTest.java @@ -36,6 +36,7 @@ import com.google.inject.Provider; import com.google.inject.spi.DefaultBindingTargetVisitor; import com.google.inject.spi.Element; import com.google.inject.spi.Elements; +import com.google.inject.util.Providers; import org.junit.Test; import static com.tavianator.sangria.test.SangriaMatchers.*; @@ -62,15 +63,26 @@ public class LazyTest { @Singleton private static class CountingProvider implements Provider { int count = 0; + private final Provider impl; @Inject CountingProvider() { + this.impl = new Provider() { + @Override + public Abstract get() { + return new Abstract() { }; + } + }; + } + + CountingProvider(Abstract instance) { + this.impl = Providers.of(instance); } @Override public Abstract get() { ++count; - return new Abstract() { }; + return impl.get(); } } @@ -186,6 +198,19 @@ public class LazyTest { assertThat(module, followsBestPractices()); } + @Test + public void testNull() { + Module module = new AbstractModule() { + @Override + protected void configure() { + bind(CountingProvider.class) + .toInstance(new CountingProvider(null)); + } + }; + + test(Guice.createInjector(module), HasLazy.class); + } + @Test(expected = CreationException.class) public void testMissingBinding() { Guice.createInjector(new AbstractModule() { -- cgit v1.2.3