From 97d9b60f0fff735bace4653f3b321592ba4ed1cc Mon Sep 17 00:00:00 2001 From: Tavian Barnes Date: Wed, 8 Apr 2009 22:26:04 +0000 Subject: Remove non-portable inline functions. --- libdimension/Makefile.am | 2 +- libdimension/dimension.h | 4 -- libdimension/dimension/geometry.h | 57 +++++---------------------- libdimension/geometry.c | 81 +++++++++++++++++++++++++++++++++++++++ libdimension/inlines.c | 22 ----------- 5 files changed, 92 insertions(+), 74 deletions(-) create mode 100644 libdimension/geometry.c delete mode 100644 libdimension/inlines.c diff --git a/libdimension/Makefile.am b/libdimension/Makefile.am index 9338b38..69bcbb3 100644 --- a/libdimension/Makefile.am +++ b/libdimension/Makefile.am @@ -21,5 +21,5 @@ nobase_include_HEADERS = dimension.h dimension/geometry.h dimension/color.h dime lib_LTLIBRARIES = libdimension.la -libdimension_la_SOURCES = dimension.h dimension/geometry.h dimension/color.h dimension/canvas.h canvas.c color.c inlines.c +libdimension_la_SOURCES = dimension.h dimension/geometry.h dimension/color.h dimension/canvas.h canvas.c color.c geometry.c libdimension_la_LDFLAGS = -version-info 0:0:0 diff --git a/libdimension/dimension.h b/libdimension/dimension.h index c52ae31..558c9ed 100644 --- a/libdimension/dimension.h +++ b/libdimension/dimension.h @@ -28,10 +28,6 @@ extern "C" { #endif -#ifndef DMNSN_INLINE -#define DMNSN_INLINE extern inline -#endif - #include #include #include diff --git a/libdimension/dimension/geometry.h b/libdimension/dimension/geometry.h index 11a6daf..6493407 100644 --- a/libdimension/dimension/geometry.h +++ b/libdimension/dimension/geometry.h @@ -31,50 +31,17 @@ typedef struct { dmnsn_scalar x, y, z; } dmnsn_vector; /* Vector arithmetic */ -DMNSN_INLINE dmnsn_vector -dmnsn_vector_construct(dmnsn_scalar x, dmnsn_scalar y, dmnsn_scalar z) -{ - dmnsn_vector v = { .x = x, .y = y, .z = z }; - return v; -} +dmnsn_vector dmnsn_vector_construct(dmnsn_scalar x, + dmnsn_scalar y, + dmnsn_scalar z); -DMNSN_INLINE dmnsn_vector -dmnsn_vector_add(dmnsn_vector lhs, dmnsn_vector rhs) -{ - return dmnsn_vector_construct(lhs.x + rhs.x, lhs.y + rhs.y, lhs.z + rhs.z); -} +dmnsn_vector dmnsn_vector_add(dmnsn_vector lhs, dmnsn_vector rhs); +dmnsn_vector dmnsn_vector_sub(dmnsn_vector lhs, dmnsn_vector rhs); +dmnsn_vector dmnsn_vector_mul(dmnsn_scalar lhs, dmnsn_vector rhs); +dmnsn_vector dmnsn_vector_div(dmnsn_vector lhs, dmnsn_scalar rhs); -DMNSN_INLINE dmnsn_vector -dmnsn_vector_sub(dmnsn_vector lhs, dmnsn_vector rhs) -{ - return dmnsn_vector_construct(lhs.x - rhs.x, lhs.y - rhs.y, lhs.z - rhs.z); -} - -DMNSN_INLINE dmnsn_vector -dmnsn_vector_mul(dmnsn_scalar lhs, dmnsn_vector rhs) -{ - return dmnsn_vector_construct(lhs*rhs.x, lhs*rhs.y, lhs*rhs.z); -} - -DMNSN_INLINE dmnsn_vector -dmnsn_vector_div(dmnsn_vector lhs, dmnsn_scalar rhs) -{ - return dmnsn_vector_construct(lhs.x/rhs, lhs.y/rhs, lhs.z/rhs); -} - -DMNSN_INLINE dmnsn_scalar -dmnsn_vector_dot(dmnsn_vector lhs, dmnsn_vector rhs) -{ - return lhs.x*rhs.x + lhs.y*rhs.y + lhs.z*rhs.z; -} - -DMNSN_INLINE dmnsn_vector -dmnsn_vector_cross(dmnsn_vector lhs, dmnsn_vector rhs) -{ - return dmnsn_vector_construct(lhs.y*rhs.z - lhs.z*rhs.y, - lhs.z*rhs.x - lhs.x*rhs.z, - lhs.x*rhs.y - lhs.y*rhs.x); -} +dmnsn_scalar dmnsn_vector_dot(dmnsn_vector lhs, dmnsn_vector rhs); +dmnsn_vector dmnsn_vector_cross(dmnsn_vector lhs, dmnsn_vector rhs); /* A line, or ray. */ typedef struct { @@ -83,10 +50,6 @@ typedef struct { } dmnsn_line; /* A point on a line, defined by x0 + t*n */ -DMNSN_INLINE dmnsn_vector -dmnsn_line_point(dmnsn_line l, dmnsn_scalar t) -{ - return dmnsn_vector_add(l.x0, dmnsn_vector_mul(t, l.n)); -} +dmnsn_vector dmnsn_line_point(dmnsn_line l, dmnsn_scalar t); #endif /* DIMENSION_GEOMETRY_H */ diff --git a/libdimension/geometry.c b/libdimension/geometry.c new file mode 100644 index 0000000..c6909f4 --- /dev/null +++ b/libdimension/geometry.c @@ -0,0 +1,81 @@ +/************************************************************************* + * Copyright (C) 2008 Tavian Barnes * + * * + * This file is part of Dimension. * + * * + * Dimension is free software; you can redistribute it and/or modify it * + * under the terms of the GNU Lesser General Public License as published * + * by the Free Software Foundation; either version 3 of the License, or * + * (at your option) any later version. * + * * + * Dimension is distributed in the hope that it will be useful, but * + * WITHOUT ANY WARRANTY; without even the implied warranty of * + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * + * Lesser General Public License for more details. * + * * + * You should have received a copy of the GNU Lesser General Public * + * License along with this program. If not, see * + * . * + *************************************************************************/ + +#include "dimension.h" + +dmnsn_vector +dmnsn_vector_construct(dmnsn_scalar x, dmnsn_scalar y, dmnsn_scalar z) +{ + dmnsn_vector v = { .x = x, .y = y, .z = z }; + return v; +} + +dmnsn_vector +dmnsn_vector_add(dmnsn_vector lhs, dmnsn_vector rhs) +{ + dmnsn_vector v = { .x = lhs.x + rhs.x, + .y = lhs.y + rhs.y, + .z = lhs.z + rhs.z }; + return v; +} + +dmnsn_vector +dmnsn_vector_sub(dmnsn_vector lhs, dmnsn_vector rhs) +{ + dmnsn_vector v = { .x = lhs.x - rhs.x, + .y = lhs.y - rhs.y, + .z = lhs.z - rhs.z }; + return v; +} + +dmnsn_vector +dmnsn_vector_mul(dmnsn_scalar lhs, dmnsn_vector rhs) +{ + dmnsn_vector v = { .x = lhs*rhs.x, .y = lhs*rhs.y, .z = lhs*rhs.z }; + return v; +} + +dmnsn_vector +dmnsn_vector_div(dmnsn_vector lhs, dmnsn_scalar rhs) +{ + dmnsn_vector v = { .x = lhs.x/rhs, .y = lhs.y/rhs, .z = lhs.z/rhs }; + return v; +} + +dmnsn_scalar +dmnsn_vector_dot(dmnsn_vector lhs, dmnsn_vector rhs) +{ + return lhs.x*rhs.x + lhs.y*rhs.y + lhs.z*rhs.z; +} + +dmnsn_vector +dmnsn_vector_cross(dmnsn_vector lhs, dmnsn_vector rhs) +{ + dmnsn_vector v = { .x = lhs.y*rhs.z - lhs.z*rhs.y, + .y = lhs.z*rhs.x - lhs.x*rhs.z, + .z = lhs.x*rhs.y - lhs.y*rhs.x }; + return v; +} + +dmnsn_vector +dmnsn_line_point(dmnsn_line l, dmnsn_scalar t) +{ + return dmnsn_vector_add(l.x0, dmnsn_vector_mul(t, l.n)); +} diff --git a/libdimension/inlines.c b/libdimension/inlines.c deleted file mode 100644 index 51348fa..0000000 --- a/libdimension/inlines.c +++ /dev/null @@ -1,22 +0,0 @@ -/************************************************************************* - * Copyright (C) 2008 Tavian Barnes * - * * - * This file is part of Dimension. * - * * - * Dimension is free software; you can redistribute it and/or modify it * - * under the terms of the GNU Lesser General Public License as published * - * by the Free Software Foundation; either version 3 of the License, or * - * (at your option) any later version. * - * * - * Dimension is distributed in the hope that it will be useful, but * - * WITHOUT ANY WARRANTY; without even the implied warranty of * - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * - * Lesser General Public License for more details. * - * * - * You should have received a copy of the GNU Lesser General Public * - * License along with this program. If not, see * - * . * - *************************************************************************/ - -#define DMNSN_INLINE -#include "dimension.h" -- cgit v1.2.3