From e8557caace66b058e3048de7eff954baaa6c0493 Mon Sep 17 00:00:00 2001
From: Tavian Barnes <tavianator@tavianator.com>
Date: Wed, 6 Sep 2017 23:05:35 -0400
Subject: parse: Don't reorder or remove tests with potential side effects

-empty and -xtype may have side effects like reporting permission
errors, which even affect the exit status of bfs.  We shouldn't remove
these effects without -Ofast.
---
 tests.sh | 8 ++++++++
 1 file changed, 8 insertions(+)

(limited to 'tests.sh')

diff --git a/tests.sh b/tests.sh
index 620bc2a..2007d0a 100755
--- a/tests.sh
+++ b/tests.sh
@@ -374,6 +374,7 @@ gnu_tests=(
 bfs_tests=(
     test_type_multi
     test_xtype_multi
+    test_xtype_reorder
     test_perm_symbolic_trailing_comma
     test_perm_symbolic_double_comma
     test_perm_symbolic_missing_action
@@ -755,6 +756,13 @@ function test_xtype_multi() {
     bfs_diff links -xtype f,d,c 2>/dev/null
 }
 
+function test_xtype_reorder() {
+    # Make sure -xtype is not reordered in front of anything -- if -xtype runs
+    # before -links 100, it will report an ELOOP error
+    bfs_diff links -links 100 -xtype l
+    invoke_bfs links -links 100 -xtype l
+}
+
 function test_iname() {
     bfs_diff basic -iname '*F*'
 }
-- 
cgit v1.2.3