From 82f7f9ee1849947ed6de227279e623d8fc3a1ee1 Mon Sep 17 00:00:00 2001
From: Tavian Barnes <tavianator@tavianator.com>
Date: Thu, 24 Feb 2022 15:56:08 -0500
Subject: regex: Rework error handling

---
 parse.c | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

(limited to 'parse.c')

diff --git a/parse.c b/parse.c
index 066784c..826d325 100644
--- a/parse.c
+++ b/parse.c
@@ -2269,24 +2269,25 @@ static struct expr *parse_regex(struct parser_state *state, int flags, int arg2)
 		goto fail;
 	}
 
-	int err;
-	expr->regex = bfs_regcomp(expr->sdata, state->regex_type, flags, &err);
-	if (!expr->regex) {
-		char *str = bfs_regerror(err, NULL);
-		if (str) {
-			parse_error(state, "${blu}%s${rs} ${bld}%s${rs}: %s.\n", expr->argv[0], expr->argv[1], str);
-			free(str);
-		} else {
+	if (bfs_regcomp(&expr->regex, expr->sdata, state->regex_type, flags) != 0) {
+		if (!expr->regex) {
+			parse_perror(state, "bfs_regcomp()");
+			goto fail;
+		}
+
+		char *str = bfs_regerror(expr->regex);
+		if (!str) {
 			parse_perror(state, "bfs_regerror()");
+			goto fail;
 		}
-		goto fail_regex;
+
+		parse_error(state, "${blu}%s${rs} ${bld}%s${rs}: %s.\n", expr->argv[0], expr->argv[1], str);
+		free(str);
+		goto fail;
 	}
 
 	return expr;
 
-fail_regex:
-	free(expr->regex);
-	expr->regex = NULL;
 fail:
 	free_expr(expr);
 	return NULL;
-- 
cgit v1.2.3