From ccf75c74bdac06eec97a2a6a5228c2e706c121bd Mon Sep 17 00:00:00 2001 From: Tavian Barnes Date: Fri, 18 Sep 2020 17:34:03 -0400 Subject: Don't call stat() just to determine symbolic lengths The new bftw_cached_stat() helper gets us stat info if we already have it, but doesn't call stat() if we don't. In that case we just take a guess for the initial length to readlinkat(). This lets us avoid stat() entirely in many cases for -lname and -printf %l. --- color.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'color.c') diff --git a/color.c b/color.c index 11684ef..4b70e19 100644 --- a/color.c +++ b/color.c @@ -841,11 +841,8 @@ static int print_path(CFILE *cfile, const struct BFTW *ftwbuf) { static int print_link_target(CFILE *cfile, const struct BFTW *ftwbuf) { int ret = -1; - size_t len = 0; - const struct bfs_stat *statbuf = bftw_stat(ftwbuf, BFS_STAT_NOFOLLOW); - if (statbuf) { - len = statbuf->size; - } + const struct bfs_stat *statbuf = bftw_cached_stat(ftwbuf, BFS_STAT_NOFOLLOW); + size_t len = statbuf ? statbuf->size : 0; char *target = xreadlinkat(ftwbuf->at_fd, ftwbuf->at_path, len); if (!target) { -- cgit v1.2.3