Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | bit: Use predefined __*_WIDTH__ macros if we can | Tavian Barnes | 2023-09-26 | 1 | -24/+69 |
| | |||||
* | dstring: New dchar typedef for dynamic strings | Tavian Barnes | 2023-09-26 | 11 | -64/+85 |
| | |||||
* | Use the new list macros | Tavian Barnes | 2023-09-25 | 5 | -26/+22 |
| | |||||
* | list: New for_[s]list() macros | Tavian Barnes | 2023-09-25 | 1 | -2/+60 |
| | |||||
* | list: Unify formatting | Tavian Barnes | 2023-09-25 | 1 | -16/+32 |
| | |||||
* | list: New [S]LIST_EMPTY() macros | Tavian Barnes | 2023-09-25 | 1 | -0/+18 |
| | |||||
* | list: New [S]LIST_ITEM_INIT() macros | Tavian Barnes | 2023-09-25 | 1 | -22/+52 |
| | |||||
* | list: Use (void)(...) rather than do { ... } while (0) | Tavian Barnes | 2023-09-25 | 1 | -31/+30 |
| | | | | This makes everything usable in expression contexts. | ||||
* | bftw: Share the bftw_state between iterations of ids/eds | Tavian Barnes | 2023-09-13 | 1 | -72/+71 |
| | |||||
* | parse: Give more ephemeral_fds to -no{user,group} | Tavian Barnes | 2023-09-12 | 1 | -7/+9 |
| | | | | | | | | Fewer than 3 can lead to Assertion failed: (retval->write_queue != -1), function __open_cached_connection, file /usr/src/lib/libc/net/nscachedcli.c, line 224. on a FreeBSD system with LDAP accounts. | ||||
* | Release 3.0.23.0.2 | Tavian Barnes | 2023-09-06 | 1 | -1/+1 |
| | |||||
* | bfstd: Work around a FreeBSD-specific msan issue | Tavian Barnes | 2023-09-06 | 1 | -4/+23 |
| | | | | Link: https://github.com/llvm/llvm-project/issues/65532 | ||||
* | bfstd: Skip a whole loop in dollar_quote() if possible | Tavian Barnes | 2023-09-06 | 1 | -2/+1 |
| | |||||
* | bfstd: Fix printable_len() off-by-one | Tavian Barnes | 2023-09-06 | 1 | -2/+2 |
| | | | | | | | If xmbrtowc() fails, or if xiswprint() is false, then we shouldn't include that wide char in the printable length. Fixes: 19c96abe0a1ee56cf206fd5e87defb1fd3e0daa5 | ||||
* | bfstd: Fix an OOB string index in xmbrtowc() | Tavian Barnes | 2023-09-06 | 1 | -6/+2 |
| | | | | | | | | | | | | | | | | | | | | | | This bug could be reproduced with something like $ bfs -samefile $'\xFA\xFA' bfs: error: bfs: dstrnescat@src/dstring.c:252: wordesc() result truncated or worse, with -DNDEBUG, $ bfs -samefile $'.....................\xFA\xFA' bfs: error: bfs -samefile $'.....................\xFA\xFA\x00\x55\x53\x45\x52\x3D\x74\x61\x76\x69\x61\x6E\x61\x74\x6F\x72 bfs: error: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ bfs: error: No such file or directory. which prints the memory after the end of the string (in this case, the environment variable USER=tavianator). The bug was caused by the line `*i += len`, which was intended to be `*i = len`. But actually, the right behaviour seems to be `*i += 1`. Fixes: 19c96abe0a1ee56cf206fd5e87defb1fd3e0daa5 | ||||
* | bftw: Enforce the dirlimit strictly | Tavian Barnes | 2023-09-06 | 1 | -19/+17 |
| | | | | | | The previous accounting didn't fully control the number of allocated bfs_dirs, as the dirlimit was incremented once we popped the directory, not when we freed it. | ||||
* | pwcache: Don't use _SC_GET{PW,GR}_R_SIZE_MAX | Tavian Barnes | 2023-08-31 | 1 | -23/+9 |
| | | | | | They tend be 1024, which is a lot of memory per user/group. 128 is usually enough, so start there instead. | ||||
* | pwcache: Arena-allocate struct passwd/group | Tavian Barnes | 2023-08-31 | 1 | -54/+80 |
| | |||||
* | alloc: New varena_grow() function | Tavian Barnes | 2023-08-31 | 2 | -0/+29 |
| | |||||
* | trie: New trie_clear() function | Tavian Barnes | 2023-08-31 | 3 | -2/+14 |
| | |||||
* | alloc: New [v]arena_clear() functions | Tavian Barnes | 2023-08-31 | 2 | -1/+25 |
| | |||||
* | Work around https://github.com/llvm/llvm-project/issues/64946 | Tavian Barnes | 2023-08-23 | 1 | -0/+3 |
| | |||||
* | ioq: New ioq_slot_monitor() helper | Tavian Barnes | 2023-08-23 | 1 | -4/+8 |
| | |||||
* | parse: Allow -files0-from an empty set of paths | Tavian Barnes | 2023-08-14 | 1 | -10/+3 |
| | | | | This follows a behaviour change in GNU findutils 4.9.0. | ||||
* | bfstd: Don't label a declaration | Tavian Barnes | 2023-08-08 | 1 | -1/+1 |
| | |||||
* | stat: Don't check for statx() mask bits we already checked for | Tavian Barnes | 2023-08-07 | 1 | -31/+15 |
| | |||||
* | bfstd: Check multiple chars at once for isascii() | Tavian Barnes | 2023-08-07 | 1 | -3/+20 |
| | |||||
* | bfstd: Speed up wordesc() by caching isprint()/isspace() | Tavian Barnes | 2023-08-07 | 1 | -2/+29 |
| | |||||
* | bit: Add a cast to squelch -Wsign-compare | Tavian Barnes | 2023-07-24 | 1 | -1/+1 |
| | | | | I see this only with musl-gcc for some reason. | ||||
* | Release 3.0.13.0.1 | Tavian Barnes | 2023-07-18 | 1 | -1/+1 |
| | |||||
* | bftw: Use bftw_file->next for multiple lists | Tavian Barnes | 2023-07-18 | 1 | -29/+21 |
| | | | | | A file can be on the to_open and to_read lists at the same time, but otherwise only one list, so we can save memory by sharing the pointers. | ||||
* | bftw: Use a larger ioq depth | Tavian Barnes | 2023-07-18 | 1 | -22/+12 |
| | | | | | | | Now that the dirlimit provides backpressure on the number of open directories, we can use a uniformly larger queue depth for increased performance. The current parameters were tuned with a small grid search on my workstation. | ||||
* | bftw: Add a queue of directories to unwrap | Tavian Barnes | 2023-07-18 | 1 | -7/+22 |
| | | | | | | | | For !BFS_USE_UNWRAPDIR, if a file is still pinned in bftw_closedir(), it has to stay open until its pincount drops to zero. Since this happens in bftw_ioq_pop(), we can't immediately call bftw_unwrapdir() as that adds to the ioq. Instead, add it to a list that gets drained by the next bftw_gc(). | ||||
* | bftw: Add dirs to the end of the queue in bftw_ioq_pop() | Tavian Barnes | 2023-07-18 | 1 | -11/+25 |
| | | | | | | I tried this before in #105 but it led to performance regressions. The key to avoiding those regressions is to put some backpressure on how many bfs_dir's can be allocated simultaneously. | ||||
* | bftw: Use separate queues for open and closed directories | Tavian Barnes | 2023-07-17 | 1 | -89/+115 |
| | |||||
* | bftw: Check that file->fd == bfs_dirfd(file->dir) earlier | Tavian Barnes | 2023-07-17 | 1 | -2/+3 |
| | | | | | | | This has the potential to fail on at least one known platform: macports with the legacysupport implementation of fdopendir(). Link: https://github.com/macports/macports-ports/pull/19047#issuecomment-1636059809 | ||||
* | bftw: Reserve space in the cache before opening files | Tavian Barnes | 2023-07-17 | 1 | -3/+15 |
| | | | | | | | This fixes a storm of EMFILE retries observed with -j1 on a very large directory tree. Fixes: 7888fbababd22190e9f919fc272957426a27969e | ||||
* | bftw: Pass the whole bftw_state to bftw_openat() | Tavian Barnes | 2023-07-17 | 1 | -510/+451 |
| | | | | | This required shuffling a lot of code around. Hopefully the new order makes more sense. | ||||
* | bftw: Add bfs_dir allocation wrappers | Tavian Barnes | 2023-07-17 | 1 | -9/+19 |
| | |||||
* | bfstd: Add an ASCII fast path to wordesc() | Tavian Barnes | 2023-07-13 | 1 | -59/+100 |
| | |||||
* | alloc: Use a different error code for size overflows | Tavian Barnes | 2023-07-13 | 1 | -0/+10 |
| | | | | This should help debuggability, and also squelches a GCC warning. | ||||
* | color: Only highlight the trailing slash on ENOTDIR | Tavian Barnes | 2023-07-13 | 1 | -2/+4 |
| | |||||
* | color: Don't break up leading and trailing dirs | Tavian Barnes | 2023-07-13 | 1 | -27/+32 |
| | |||||
* | color: TTY-escape filenames | Tavian Barnes | 2023-07-13 | 3 | -3/+12 |
| | |||||
* | color: Get rid of EXT_MAX | Tavian Barnes | 2023-07-13 | 1 | -10/+30 |
| | |||||
* | bfstd: Support wordesc() without allocating | Tavian Barnes | 2023-07-13 | 7 | -70/+175 |
| | |||||
* | bfstd: Quote the whole string the same way in wordesc() | Tavian Barnes | 2023-07-13 | 1 | -77/+101 |
| | |||||
* | bfstd: Use $'\n' etc. over $'\x0A' | Tavian Barnes | 2023-07-13 | 1 | -5/+35 |
| | |||||
* | bfstd: Escape '!' in wordesc() | Tavian Barnes | 2023-07-13 | 1 | -2/+2 |
| | |||||
* | parse: Reject -j0 | Tavian Barnes | 2023-07-12 | 1 | -1/+9 |
| |