Unify broken symlink handling

Rather than open-code the fallback logic for broken symlinks everywhere
it's needed, introduce a new xfstatat() utility function that performs
the fallback automatically.

Using xfstatat() consistently fixes a few bugs, including cases where
broken symlinks are given as arguments to predicates like -samefile.

1 files changed, 15 insertions, 0 deletions

diff --git a/util.h b/util.h
index b2025e6..6798fb9 100644
--- a/util.h
+++ b/util.h
@@ -143,6 +143,21 @@ void format_mode(mode_t mode, char str[11]);
 const char *xbasename(const char *path);
 
 /**
+ * stat() a file, falling back on the link itself for broken symbolic links.
+ *
+ * @param fd
+ *         The base directory descriptor.
+ * @param path
+ *         The path to the file, relative to fd.
+ * @param buf
+ *         The stat buffer to fill.
+ * @param flags
+ *         AT_* flags for this call.  Will be updated if a fallback happens.
+ * @return 0 on success, -1 on failure.
+ */
+int xfstatat(int fd, const char *path, struct stat *buf, int *flags);
+
+/**
  * Convert a stat() st_mode to a bftw() typeflag.
  */
 enum bftw_typeflag mode_to_typeflag(mode_t mode);