diff options
| author | Tavian Barnes <tavianator@tavianator.com> | 2023-11-15 09:45:49 -0500 |
|---|---|---|
| committer | Tavian Barnes <tavianator@tavianator.com> | 2023-11-15 09:54:18 -0500 |
| commit | fb4760db85c552b0f538f7af2ad40fa631c20540 (patch) | |
| tree | e72288d2effb4079c2a63a68ff52cd2d1ac25afe /tests | |
| parent | 8b312eb6553235c36f5483d4e46c5034dcc03ce2 (diff) | |
| download | bfs-fb4760db85c552b0f538f7af2ad40fa631c20540.tar.xz | |
tests: Fix a possible infinite loop
The POSIX spec for readdir() [1] says:
> If a file is removed from or added to the directory after the most
> recent call to opendir() or rewinddir(), whether a subsequent call
> to readdir() returns an entry for that file is unspecified.
which implies that a loop of readdir()/unlink()/creat() may continue to
return new files unendingly. This was even observed on a Linux 6.6
tmpfs mount [2].
It's not clear whether find(1) is also permitted to loop endlessly in
this case, but in case it is, let's avoid the whole problem by limiting
the -exec to happen at most once.
[1]: https://pubs.opengroup.org/onlinepubs/9699919799/functions/readdir.html
[2]: https://lore.kernel.org/linux-fsdevel/20231113180616.2831430-1-tavianator@tavianator.com/
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/gnu/ignore_readdir_race_notdir.sh | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/tests/gnu/ignore_readdir_race_notdir.sh b/tests/gnu/ignore_readdir_race_notdir.sh index 8b03164..12e9fe6 100644 --- a/tests/gnu/ignore_readdir_race_notdir.sh +++ b/tests/gnu/ignore_readdir_race_notdir.sh @@ -1,5 +1,7 @@ # Check -ignore_readdir_race handling when a directory is replaced with a file cd "$TEST" -"$XTOUCH" -p foo/bar +mkdir foo -invoke_bfs . -mindepth 1 -ignore_readdir_race -execdir rm -r {} \; -execdir "$XTOUCH" {} \; +invoke_bfs . -mindepth 1 -ignore_readdir_race \ + -type d -execdir rmdir {} \; \ + -execdir "$XTOUCH" {} \; |