diff options
| author | Tavian Barnes <tavianator@tavianator.com> | 2024-02-12 14:36:52 -0500 |
|---|---|---|
| committer | Tavian Barnes <tavianator@tavianator.com> | 2024-02-12 14:36:52 -0500 |
| commit | 4ddbaf8a44e4bf46d3ebe3c5afc957ecd07cfa0a (patch) | |
| tree | 0a7931c79ea13b9032a8e4958f88024b084feacc /src/parse.c | |
| parent | a98fe72db88350fcec030487208e6c50c9de1974 (diff) | |
| download | bfs-4ddbaf8a44e4bf46d3ebe3c5afc957ecd07cfa0a.tar.xz | |
sanity: Don't use self-init for uninit()
Self-initialization like
bool ret = ret;
is a GCC trick to suppress uninitialized variable warnings, but it's not
actually well-defined, and will trip a recent enough MemorySanitizer:
src/eval.c:1088:13: runtime error: load of value 128, which is not a valid value for type 'bool'
Diffstat (limited to 'src/parse.c')
| -rw-r--r-- | src/parse.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/parse.c b/src/parse.c index 3a78840..5d0f333 100644 --- a/src/parse.c +++ b/src/parse.c @@ -1891,11 +1891,11 @@ static int parse_mode(const struct bfs_parser *parser, const char *mode, struct MODE_PLUS, MODE_MINUS, MODE_EQUALS, - } op = uninit(op, MODE_EQUALS); + } op uninit(MODE_EQUALS); - mode_t who = uninit(who, 0); - mode_t file_change = uninit(file_change, 0); - mode_t dir_change = uninit(dir_change, 0); + mode_t who uninit(0); + mode_t file_change uninit(0); + mode_t dir_change uninit(0); const char *i = mode; while (true) { |