Redirect stdin from /dev/null for -ok and -okdir.

1 files changed, 4 insertions, 32 deletions

diff --git a/main.c b/main.c
index 03c5020..7471156 100644
--- a/main.c
+++ b/main.c
@@ -10,6 +10,7 @@
  *********************************************************************/
 
 #include "bfs.h"
+#include "util.h"
 #include <errno.h>
 #include <fcntl.h>
 #include <stdio.h>
@@ -17,43 +18,14 @@
 #include <unistd.h>
 
 /**
- * Check if a file descriptor is open.
- */
-static bool is_fd_open(int fd) {
-	return fcntl(fd, F_GETFD) >= 0 || errno != EBADF;
-}
-
-/**
  * Ensure that a file descriptor is open.
  */
 static int ensure_fd_open(int fd, int flags) {
-	if (is_fd_open(fd)) {
+	if (isopen(fd)) {
 		return 0;
+	} else {
+		return redirect(fd, "/dev/null", flags);
 	}
-
-	int devnull = open("/dev/null", flags);
-	if (devnull < 0) {
-		perror("open()");
-		return -1;
-	}
-
-	int ret = 0;
-
-	if (devnull != fd) {
-		// Probably not reachable
-
-		if (dup2(devnull, fd) < 0) {
-			perror("dup2()");
-			ret = -1;
-		}
-
-		if (close(devnull) != 0) {
-			perror("close()");
-			ret = -1;
-		}
-	}
-
-	return ret;
 }
 
 /**